UI Tests for Block Mover #27883
UI Tests for Block Mover #27883
Conversation
gziolo
added
[Type] Automated Testing
There was a problem hiding this comment.
The failing tests don't have video links for some reason on CircleCI so I couldn't watch them. Will try to login to saucelabs.com later to do that instead.
I'm making a few more changes in this PR: #27381
After it is merged, the iteration on this PR could be faster by adding -@canary to the filename temporarily (and maybe also removing -@canary from others), so only this test runs on CircleCI.
packages/react-native-editor/__device-tests__/gutenberg-editor-move-block.test.js
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/gutenberg-editor-move-block.test.js
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/gutenberg-editor-move-block.test.js
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/pages/editor-page.js
Outdated
Show resolved
Hide resolved
| await typeString( this.driver, textViewElement, text, clear ); | ||
| await this.driver.sleep( 1000 ); // Give time for the block to rerender (such as for accessibility) | ||
| if ( ! isAndroid() ) { | ||
| block.type( text ); |
There was a problem hiding this comment.
This seemed to be the failure reason for some of the e2e tests. What was the reason behind this change?
There was a problem hiding this comment.
I changed this because locally my machine wouldn't type anything on iOS with that function. Not sure if I have something set up wrong?
There was a problem hiding this comment.
Which iOS simulator (version, device) were you using?
packages/react-native-editor/__device-tests__/pages/editor-page.js
Outdated
Show resolved
Hide resolved
| block.click(); | ||
| } | ||
|
|
||
| async tapCoordinates( x, y, longPress = false ) { |
There was a problem hiding this comment.
If possible, using clickMiddleOfElement instead could be more robust. The device size, running locally or in the cloud, could be different and coordinates may not be the same between them.
There was a problem hiding this comment.
Hmmm. The problem is that I need to click outside of the alert and I can't get elements behind the alert.
There was a problem hiding this comment.
Would pressing the back button instead on Android work?
…ng at gutenberg-mobile. Adding more convenience functions to EditorPage.
WC: Cleaning up code. WC: Fixing merge issue where import was changed to const. WC: Changing all imports to requires as per jest bug. WC: Removing before/afterAll blocks from UI tests. WC: Updating UI tests to align with UI test changes.
… new UI test EditorPage.
Description
Original issue link:1191Gutenberg-mobile link:PR 2930UI Tests for move to top/bottom block mover functionality.
Types of changes
New feature added.
Checklist: