-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Add block insertion flow e2e test #27381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
gziolo
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Nov 30, 2020
ceyhun
changed the title
[RNMobile] Add block insertion flow e2e
[RNMobile] Add block insertion flow e2e test
Dec 1, 2020
cameronvoell
force-pushed
the
rnmobile/add-block-insertion-flow-e2e
branch
2 times, most recently
from
December 30, 2020 19:23
59eb778
to
d3761e0
Compare
cameronvoell
approved these changes
Dec 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Nice job adding the block insertion tests 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
testNamePattern
was used to run/skip tests. UsedtestPathPattern
instead changing the names of tests to make sure the setup is also skipped when tests are skipped.Show html
button on Android using XPath.Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#2851
How has this been tested?
npm run native test:e2e:ios:local
andnpm run native test:e2e:android:local
should work as before.Checklist: