Use a consistent way to check isRTL #27838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
Internationalization (i18n)
youknowriad
requested review from
ajitbohra,
ajlende,
chrisvanpatten and
talldan
as code owners
|
Size Change: -141 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Dec 21, 2020
gziolo
approved these changes
Dec 21, 2020
This was referenced Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our codebase, we have 3 or 4 different ways of checking whether the locale is RTL or LTR. this PR consolidates the way we do this on web code using i18n. The reason for choosing this one is because it's low-level (works in reusable packages) and it's not an implementation detail (like the dir on body).
The native code is still inconsistent but I didn't want to touch it seems it seems to have its own i18nManager. cc @Tug @ceyhun