-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use @wordpress/stylelint-config in @wordpress/scripts #27810
Conversation
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
@ocean90, I'll have a look at the issue you described Monday at the latest 👍🏻 |
@gziolo Sorry, read the docs again and I was missing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thank you for wrangling it ❤️
I'm wondering if we want to batch more changes for the next major version of @wordpress/scripts
. There is also PR (#26382) from @jsnajdr that upgrades webpack from v4 to v5 waiting to be merged.
There is also approved PR (#27327) from @sirreal that enabled new ESLint rules.
Some other items that we should consider:
- Update @wordpress/scripts to use PostCSS 8 Update @wordpress/scripts to use PostCSS 8 #27028
- Upgrade Jest to the new major version (26.x) Scripts: Upgrade Jest to the new major version (26.x) #22395
I created a milestone to make it easier to track what could go in the next major release of The alternative approach is to merge breaking changes as they are ready (this is what we’ve been doing so far) and accept the fact that we have more often breaking changes. As far as I can tell, well-established projects (Jest, ESLint, Babel) try to minimize the number of major releases but we depend on them so it’s complicated 😃 |
279d855
to
44f012c
Compare
I rebased this PR with the latest changes in the main branch. If CI checks pass it should be fine to merge it. I started merging a number of PRs that introduce breaking changes to |
There is one e2e test failing that can't be related to those changes because we introduce changes only for style linting 🤷🏻 Let's proceed. |
Description
Follow-up to #22777.
Fixes #27775.
I have trouble with updating stylelint in the
package-lock.json
. I tried the steps in https://github.com/WordPress/gutenberg/tree/master/packages#updating-existing-dependencies but it only updates the version.npm update stylelint
did nothing either. @gziolo Can you help?How has this been tested?
Screenshots
Types of changes
Checklist: