Change the week header and left button style to meet the date spacing

[hsingyuc]

Description

Fix #27536
Change the week header and left button style to meet the date spacing.

How has this been tested?

Tested in English and in Arabic (rtl), both render as expected

Screenshots

1. Before

1. After

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[jasmussen]

This is awesome! Small, focused PR! Thank you. Before:

After:

The month navigation buttons have better alignment.

I'm seeing an issue in arabic, though:

The button to navigate left takes up the whole screen. This may have been a pre-existing issue, but because this PR aims to close the ticket that reported the issue, it seems worth fixing.

From a little debugging in the inspector, I found this rule:

.components-datetime__date .DayPickerNavigation_leftButton__horizontalDefault {
    right: 13px;
}

If that gets changed to:

.components-datetime__date .DayPickerNavigation_leftButton__horizontalDefault {
    left: 13px;
}

all is fine.

In other words, it appears that the left and right positioning gets auto-rewritten for RTL, when it shouldn't be. So in the code where it says left, you can add the following line before it, to have it not be rewritten: /*rtl:ignore*/.

If we get that in, we can ship this. Thanks again.

[hsingyuc]

@jasmussen Thanks for the tip! The change has been pushed.

[jasmussen]

LTR is good:

But I'm still seeing an issue with RTL:

It looks like you need to not only be explicit about the left value, but the right value as well.

This might work:

		/*!rtl:begin:ignore*/
		left: 13px;
		right: auto;
		/*!rtl:end:ignore*/

Thanks for your patience!

[hsingyuc]

@jasmussen Thank you! The begin/end ignore is a good addition! I've pushed that change. Could you confirm if you have pulled the latest changes and built the scripts? I see the arrows properly aligned in RTL without the need for right: auto;. Thank you for your time!

[jasmussen]

Thanks again. I'm about to head out for the evening but promise I will test properly tomorrow morning my time, and approve if it works as I think it will. But in the mean time, someone else should feel free to test and approve.

[hsingyuc]

It looks like this PR may also resolve #27535.

Also, I ran into another problem with the RTL calendar. The current month appears hidden because of the positioning of months in RTL mode.

Do you see this issue?

I think there's a quick fix for this by absolutely positioning the third calendar month in the container since we don't use calendar animations in GB, but this problem may be upstream in react dates. react-dates/react-dates#1552.

[jasmussen]

Thanks so much for this PR, and thanks for the patience. With the latest changes, this is solid in LTR:

And RTL:

Here's RTL before, for comparison:

That arabic calendar does look fairly compressed to me, though, so there may be a separeate bug at play, but since that existed before this PR it's unrelated. Admittedly my Arabic is a little rusty, so I'll defer to speakers of that language.

Ship this, and thanks again!

[hsingyuc]

The pleasure is all mine 🤝