Apply hover class in outline mode #27714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Feature] Blocks
|
Size Change: +26 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
A little bit of off-topic: What's the difference between outline mode and navigate mode? 🤔 I'm trying to understand why outline mode is a thing. We already had navigate mode. Onto testing the changes. EDIT: It works fine! See review below |
| isOutlineMode: getSettings().outlineMode, | ||
| }; | ||
| }, | ||
| [ clientId ] |
There was a problem hiding this comment.
Is clientId necessary as a dependency? It works fine without it.
I don't see it as three modes, I see it as two modes, select and edit.
This remains the same in site and post editors, the only difference is that we are experimenting with also showing the block boundary in edit mode for the site editor. If this is successful it could become an option to enable in either editor. |
|
Thanks for the review @david-szabo97, I pushed an update. |
david-szabo97
approved these changes
Dec 15, 2020
packages/block-editor/src/components/block-list/use-block-props/use-is-hovered.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27543
Restores the outline effect on hover when Site Editing:
To test:
is-hoveredclass is not applied when hovering a blockis-hoveredclass is applied when hovering a block