Use clientWidth when no width is available for cropper #27687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
changed the title
|
Size Change: +5 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
draganescu
added
[Block] Image
stokesman
approved these changes
Dec 14, 2020
getdave
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
I tested this as per instructions to replicate in #27145.
I found on master the bug was still in evidence (except the image didn't disappear it was just very very small).
On this branch however the image remains as the correct size based on it's alignment.
I tested on Twenty Twenty One.
👍 Nice fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27145
When the image has an align property the crop container's width becomes zero. When the image is having a set width the crop container inherits it, but when it has no width, the crop container is 100% of zero, because of the float, so it results in a zero width.
With this small change, we make the crop container always have at least the clientWidth value.