Group Block: Add border radius #27665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +19 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
|
The direction regarding border radius block support and new sidebar controls/panels has changed. Until the new sidebar controls & component system lands, the preferred approach is to allow this sort of functionality via theme.json and attributes only, avoiding adding new panels or controls to the editor sidebar. Given this PR is just a simple opt-in for the block support, the code hasn't changed, but the method of testing this should. The testing instructions have been updated accordingly. |
aaronrobertshaw
force-pushed
the
add/border-radius-to-group-block
branch
from
095ef45 to
610f8d7
Compare
apeatling
approved these changes
Jan 6, 2021
aristath
approved these changes
Jan 8, 2021
aaronrobertshaw
force-pushed
the
add/border-radius-to-group-block
branch
from
610f8d7 to
a9798b9
Compare
|
I've rebased and re-run tests on this PR. The failing e2e test appears unrelated and looks to have also been failing for a fair few other commits onto master. So I'll proceed with merging this. |
|
@aaronrobertshaw do you happen to know whether this work is available in WordPress 5.8 proper please? Because, I can not get anything to work with Group block and border in Based on your merge timeline and the release of WordPress 5.8 then I'm assuming it was rolled in to WP 5.8, but I'm not privy to how to truly figure that out (beside making assumptions based on time stamps 😄 ) |
|
Hi @colorful-tones 👋 The border block support is still officially experimental. For that reason, it didn't land in WP 5.8. The behaviour you describe is to be expected. If you wish to leverage border support, you'll need to also use the Gutenberg plugin until it lands in a WordPress release. The theme.json docs outline the currently available settings in both WordPress core and Gutenberg. I hope that helps!
|
|
Thanks for the clarification @aaronrobertshaw 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26556
Description
Opts into border radius support for the group block.
How has this been tested?
Manually.
Testing Instructions
lib/experiment-default-theme.jsonfile into your active theme's root folder asexperimental-theme.jsoncore/groupcontext to your current theme.json file from step 2. It must be a top level property in the JSON as perglobal.border.customRadiusflagNote:
Instead of turning on the sidebar controls, the border radius attribute can be set via the code editor and the following block code.
Screenshots
Editor:
Frontend:
Types of changes
Enhancement/New Feature
Checklist: