Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repositioned RangeControl tooltip and adjusted image zoom control dropdown height #27374

Merged

Conversation

Tonnie-Exelero
Copy link
Contributor

Description

  • Repositioned RangeControl tooltip to the bottom so that it doesn't obscure labels.
  • Adjusted Image block zoom control dropdown height to accommodate RangeControl tooltip's new position.

How has this been tested?

  • I've tested the changes on Chrome and simulated different devices and it works as intended.
  • I've run unit tests.

Screenshots

Screenshot 2020-11-30 at 03 18 14

Types of changes

This is a Bug Fix that introduces changes that affect the positioning of the RangeControl's tooltip to prevent it from obscuring labels.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Fixes #27261

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 30, 2020
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @Tonnie-Exelero.

I think this change should be possible with fewer lines of code, but I wasn't all that familiar with the code before this review, so I'm happy to be corrected on that 😃.

I'll add a couple of other reviewers who've modified the code recently.

@Tonnie-Exelero Tonnie-Exelero force-pushed the fix/range-control-tooltip-repositioning branch from 83b2526 to afa7301 Compare December 8, 2020 22:10
Base automatically changed from master to trunk March 1, 2021 15:44
@skorasaurus skorasaurus added the [Package] Components /packages/components label Sep 17, 2021
@mkaz mkaz force-pushed the fix/range-control-tooltip-repositioning branch from 1bb6f95 to 3b9ce6e Compare October 15, 2021 23:10
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this using Storybook and tests well the tooltip position works as described and looks better than a label. The previous feedback was also addressed.

👍 Thanks for the contribution!

@mkaz mkaz merged commit 1aca873 into WordPress:trunk Oct 16, 2021
@github-actions
Copy link

Congratulations on your first merged pull request, @Tonnie-Exelero! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 11.8 milestone Oct 16, 2021
@jeffpaul
Copy link
Member

@Tonnie-Exelero pinging you again to see if you can help confirm your WordPress.org username so you can be properly credited in the WordPress 5.9 release? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Components /packages/components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RangeControl's tooltip overlaps label
5 participants