-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repositioned RangeControl tooltip and adjusted image zoom control dropdown height #27374
Repositioned RangeControl tooltip and adjusted image zoom control dropdown height #27374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @Tonnie-Exelero.
I think this change should be possible with fewer lines of code, but I wasn't all that familiar with the code before this review, so I'm happy to be corrected on that 😃.
I'll add a couple of other reviewers who've modified the code recently.
83b2526
to
afa7301
Compare
1bb6f95
to
3b9ce6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this using Storybook and tests well the tooltip position works as described and looks better than a label. The previous feedback was also addressed.
👍 Thanks for the contribution!
Congratulations on your first merged pull request, @Tonnie-Exelero! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
@Tonnie-Exelero pinging you again to see if you can help confirm your WordPress.org username so you can be properly credited in the WordPress 5.9 release? Thanks! |
Description
How has this been tested?
Screenshots
Types of changes
This is a Bug Fix that introduces changes that affect the positioning of the RangeControl's tooltip to prevent it from obscuring labels.
Checklist:
Fixes #27261