Packages: Remove package import statements in favor of store object usage #27368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
adamziel,
ajitbohra,
draganescu,
ellatrix,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
gziolo
force-pushed
the
update/package-imports-stores
branch
from
1d68802 to
b9d2265
Compare
gziolo
added
npm Packages
17 tasks
|
Size Change: -86 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/package-imports-stores
branch
from
b9d2265 to
b69f991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #27088.
It's a general cleanup PR that remove package import statements in favor of store object usage for refactored stores.
Testing
Nothing particular specific on my mind here:
npm run lint-jsnpm run test-unitnpm run test-e2eYou also might want to test manually whether Block Directory still works as expected. To do so, open a block inserter and type the name of the block that doesn't ship with Gutenberg core like:
boxer. You should be able to install it and insert through the inserter.