[Mobile] Use link picker in Image block #27292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevins
added
Mobile App - i.e. Android or iOS
2 tasks
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
mkevins
commented
Nov 27, 2020
Comment on lines
+346
to
+350
| const mappedAttributes = { ...unMappedAttributes, url }; | ||
| const setMappedAttributes = ( { url: href, ...restAttributes } ) => | ||
| href === undefined | ||
| ? setAttributes( restAttributes ) | ||
| : setAttributes( { ...restAttributes, href } ); |
There was a problem hiding this comment.
The link settings sets the attribute named url, but Image block's url attribute is the URL of the image itself, and instead uses the attribute named href to represent the link URL.
Originally, to work around this, I used dynamic properties in LinkSettings to allow the consumer to customize the attribute name to be set.
Here, I reverted those changes to LinkSettings, and instead map the attibutes in ImageEdit. As the link picker is used in more places, it might make sense to re-evaluate this pattern, depending on the commonality of the possible attribute names (e.g. url, href). WDYT?
There was a problem hiding this comment.
I like the dynamic properties approach. It seems fairly clean. The code ^ is a bit harder for me to understand. But I think this could be done as part of a larger refactor.
One thing that I noticed is that we always seem to set the options such as labels etc.
I think we could really benefit from having a default name for labels. so that we only pass in the options that are different from the default.
There was a problem hiding this comment.
I think we could really benefit from having a default name for labels. so that we only pass in the options that are different from the default.
Exactly my thoughts! I think we can refactor during the iteration for further consolidation described here. I think with the refactor we should have the opportunity to both reduce the surface area of the interface, and also make the components appropriately general (in particular, decoupled from particular attribute names and even setAttributes).
3 tasks
|
This PR worked really well for me. I tested it on the iOS simulator. I think the LinkSettings could use some better default options so that it would be harder to set the link setting labels to be different across the different instances. |
enejb
approved these changes
Dec 17, 2020
mkevins
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
Sorry for the ping.. I pushed a revert to troubleshoot the failing test: https://github.com/WordPress/gutenberg/blame/master/packages/e2e-tests/specs/experiments/multi-entity-saving.test.js#L86. |
This reverts commit f40b256.
This is an attempt to fix a failing test - I manually counted 26 assertions, instead of 27, so it looks correct. However, it still is not clear how this was passing before with 27.
|
Thank you Enej for reviewing and testing! 😃 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#2841WordPress-Android: wordpress-mobile/WordPress-Android#13576Description
This PR adds the link picker functionality to the Image block settings, and auto-hides the "Open in new tab" and "rel" settings when a link is not present. This is a first step towards resolving: wordpress-mobile/gutenberg-mobile#1655.
This also auto-hides the "Open in new tab" setting for RichText based link editing.
Testing steps
Link picker
Open in new tab
RichText auto-hiding
Screenshots
Image block link settings
Note: the above screen recordings were created prior to autohiding the "Open in new tab" and "rel" settings.
Autohide settings
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: