-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Word count: Adjust to count numbers as words #27288
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,10 +43,17 @@ describe( 'WordCounter', () => { | |
{ | ||
message: 'Punctuation.', | ||
string: 'It’s two three \u2026 4?', | ||
words: 3, | ||
words: 4, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
characters_excluding_spaces: 15, | ||
characters_including_spaces: 19, | ||
}, | ||
{ | ||
message: 'Numbers as word', | ||
string: 'Should be 4 words', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see also a comment from @Soean in #26339 (comment):
|
||
words: 4, | ||
characters_excluding_spaces: 14, | ||
characters_including_spaces: 17, | ||
}, | ||
{ | ||
message: 'Em dash.', | ||
string: 'one\u2014two--three', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that it allows now digits from 0 to 9 👍🏻