Search Block: Add rounded block style #27220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
6 tasks
aaronrobertshaw
force-pushed
the
add/search-border-radius-block-style
branch
from
39a7e2d to
25dc4b2
Compare
|
Size Change: +135 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
This tested well for me, my only question was whether there should be some extra padding on left of placeholder text when rounded chosen as text looks slightly odd at the edge of the radius, eg. Instead of this: does this look better?: Might just be a personal opinion thing so not critical I don't think |
Agreed, I'll make that update. I'm also still waiting to see if we go down this path, a separate border radius control to allow custom radius values or the full block support approach. #25791 (comment) |
aristath
approved these changes
Nov 30, 2020
apeatling
requested changes
Dec 4, 2020
There was a problem hiding this comment.
I don't think this is the direction we should go in because designers should have more fine grained control of border radius than this in order to create interesting patterns. Other examples of this need are here and here.
For now I think we should merge the block support for border radius and hold off on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new rounded block style for the search block. This will add a border radius to the search block including adding adjusted border radii to the input and button when the button is placed "inside".
This is an alternate approach to adding border radius block support as suggested in #25791 (comment)
Note: This uses a CSS variable for the border radius value. This allows;
calc()for inner elementsHow has this been tested?
Manually.
Screenshots
Types of changes
New feature.
Checklist: