-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Directory: Replace store name string with exposed store definition #27178
Block Directory: Replace store name string with exposed store definition #27178
Conversation
The build was failing before this last commit. I tried analyzing the YAML for the E2E tests; apparently, the runs are split between 4 runners... Right? And, for some reason (which I am not sure why), the build failed in the second one... I just made an empty commit, and it passed now... Edit: after some quick searching, I think that the issue could be something similar to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you for proposing this refactoring 👍
Congratulations on your first merged pull request, @rafaelgalani! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
That's quite useful. I will file an issue for that 🙇♂️ |
Description
Addresses #27088. Replaces the store names (hardcoded strings) with the exposed
store
definitions.How has this been tested?
npm run test
, no additional test was done.Screenshots
Types of changes
Code refactoring, non-breaking change.
Checklist: