Animate: type getAnimateClassName #27123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +8 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
6 tasks
ellatrix
reviewed
Nov 22, 2020
sirreal
force-pushed
the
update/deprecate-type-animate
branch
from
39ebf5a to
8d7f5a2
Compare
sirreal
requested review from
ajitbohra,
chrisvanpatten and
talldan
as code owners
sirreal
commented
Nov 25, 2020
packages/components/src/index.js
Outdated
| @@ -14,7 +14,7 @@ export { | |||
| export { default as __experimentalAlignmentMatrixControl } from './alignment-matrix-control'; | |||
| export { | |||
| default as Animate, | |||
| useAnimate as __unstableUseAnimate, | |||
| getAnimateClassName as __experimentalGetAnimateClassName, | |||
There was a problem hiding this comment.
I just noticed this was __unstable - not intended for use outside of Gutenberg. Should it stay that way?
There was a problem hiding this comment.
If we're confident in the API, we can stabilise it? The question is, do we intend to use this for future animations, or are there new methods there days? Cc @jasmussen.
There was a problem hiding this comment.
I'm sad to say I've not had enough of a chance to leverage this one quite yet, to make a call. However I recall @youknowriad being pretty excited about it?
or are there new methods there days?
I think there's a place for both, perhaps even with emphasis on the class.
There was a problem hiding this comment.
Maybe I can land this PR with the rename and keep it marked unstable. A follow-up could mark it experimental or stabilize.
Restored unstable in d510658
sirreal
force-pushed
the
update/deprecate-type-animate
branch
from
0f71b55 to
d510658
Compare
|
@ellatrix I know you approved this, but it wasn't ready at the time so I'm disregarding. I can't actually dismiss the review for some reason 🤷♂️ I do think it's ready for review at this time 🙇♂️ |
sirreal
commented
Nov 27, 2020
|
Thanks for catching those mistakes, @saramarcondes. I've cleaned them up. |
|
Consider my approval given for any additional commits. Looks like there's still a few tests failures, but other than that it looks good! |
sirreal
added
[Type] Code Quality
sirreal
force-pushed
the
update/deprecate-type-animate
branch
from
c2d6dba to
44e5917
Compare
sirreal
force-pushed
the
update/deprecate-type-animate
branch
from
53d9699 to
b0cadc6
Compare
|
I'll break this into 2 PRs - we shouldn't deprecate |
6 tasks
sirreal
removed
the
Needs Dev Note
sirreal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useAnimatetogetAnimateClassName(publicly__unstableGetAnimateClassName) and treat it as a regular function. It's implementation is not like a hook and it doesn't need to be treated as one.getAnimateClassName.Closes #26965 (supersedes).
How has this been tested?
Types of changes
getAnimateClassName.Checklist: