Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block data to REST API #2649
base: trunk
Are you sure you want to change the base?
Add block data to REST API #2649
Changes from 29 commits
d45e15c
09a8e51
f70f6bb
6f73d88
97d282b
30d12b9
488690d
632a07d
9ce9ca4
148469e
96f1fa2
2023901
b4a3a92
4c00931
5a17b33
dff3f0b
cfd2f5e
36f1000
d990979
5937d1a
862bccc
a5756f5
8340341
957dc7e
bc5f31e
5509c1b
822ffe2
6cf7a5f
23a5565
36f5df1
37513d1
daece40
1eb5331
728e725
8117871
7e8a823
bc2600d
d395197
08cdb15
9d6b95c
1e9572c
b82fa9d
cbd0c62
9374837
218299c
8d75bb7
b7ae85a
d82bfa9
951b8d6
f0355f0
55732b8
5e4db00
bd638d1
0098344
4f5c72f
1573cc4
391c0ec
7afbe67
2b37f93
b71ef00
989f0ca
74092df
2144d20
63de8af
131dd90
1c6b213
546fb81
812af84
8258cb6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When would an array be passed in? If we don't use this functionality then I'd say it's best to omit it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to add pages here already, so maybe I can simplify by always expecting an array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noisysocks - added page post type as well as filter to enable finer dev control
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe related to my previous content, I'm seeing that the post entity is now wrapped inside a
content
key in the REST response:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback & testing @aduth, I'll review these issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aduth Oops! fixed that in d395197