Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node-watch to 0.7.0 #26403

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Update node-watch to 0.7.0 #26403

merged 1 commit into from
Oct 26, 2020

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Oct 22, 2020

Description

Filesystem watching wasn't working for me on Linux. Updating to the latest version of node-watch fixed the issue for me.

OS: Arch Linux x86_64
Kernel: 5.4.72-1-lts

How has this been tested?

npm run dev on Linux runs incremental build when file is changed.

Types of changes

Bug Fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ajlende ajlende added [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling labels Oct 22, 2020
@ajlende ajlende self-assigned this Oct 22, 2020
gziolo
gziolo approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try 👍

@gziolo gziolo merged commit 4f11b4f into WordPress:master Oct 26, 2020
@github-actions github-actions bot added this to the Gutenberg 9.3 milestone Oct 26, 2020
@yaseenaljamal yaseenaljamal mentioned this pull request Sep 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees

@ajlende ajlende

Labels
[Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
Gutenberg 9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ajlende @gziolo