[RNMobile] File Block II #26360
Merged
[RNMobile] File Block II #26360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etoledom
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
@etoledom I think I'd prefer the inline feedback messaging, mainly because it's direct and much more obvious (the compact notice is way on the top of the screen and pretty subtle). I figured this could be a tricky thing when I was designing it, but it would be a nice subtle touch, and hopefully one that we can re-use elsewhere 😄 |
There was a problem hiding this comment.
Thanks for these changes @etoledom I reviewed the code and all the test scenarios described and they all worked as expected. I will do another pass once you have addressed the design feedback. 👍
etoledom
force-pushed
the
rnmobile/file-block
branch
from
8bf08a3 to
bfceb2c
Compare
etoledom
force-pushed
the
rnmobile/file-block-II
branch
2 times, most recently
from
a20c9ad to
1b72a5c
Compare
|
I have rebased and updated this branch after the merge of the first iteration PRs Copy URL behaviour has been changed as @iamthomasbishop requested:
Also, some minor style improvements:
This is the real action button color, since it looks too bad in the gif: |
|
Looks awesome, @etoledom. Thanks for taking care of that! |
jd-alexander
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
These changes are looking good @etoledom I reviewed the code and tested all the flows and they worked as expected. I left a few minor comments which you can address as you see fit. LGTM 🚢
jd-alexander
approved these changes
Nov 17, 2020
- Copy URL action button color - Media Placeholder icon color (BlockIcon mod)
etoledom
force-pushed
the
rnmobile/file-block-II
branch
from
e777c4b to
cbd7358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements most of the options for File Block:
For the copy file URL feature, I decided to close the bottom-sheet and show a notice, instead of keeping the bottom-sheet and changing the button text. @iamthomasbishop - let me know if you still prefer the later, it would be a simple change.
How has this been tested?
cogbutton)onthe "Open in new tab" option.target="_blank" rel="noreferrer noopener"attributes in the<a>tag.cogbutton).offthe "Show download button` option.<a>tag.cogbutton).Copy file URLoption.Copiedis displayed.Alight left,Wide widthand no option selected won't have visual differences.Screenshots
Types of changes
Checklist: