Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] added jetpack node_modules folder to cleanup step in JSbundle building #26247

Merged
merged 27 commits into from
Oct 23, 2020
Merged

[RNMobile] added jetpack node_modules folder to cleanup step in JSbundle building #26247

Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
12483fa
added mobile StoryUpdateProgress component and bridge code to send/re…
mzorz Sep 21, 2020
2c17055
updated WPAndroid bridge DeferredEventEmitter to handle Story save ev…
mzorz Sep 24, 2020
78455a8
changed all Save event interface methods to use String ids instead of…
mzorz Sep 24, 2020
da1a900
redefined upload/save state constants
mzorz Sep 25, 2020
9613c56
added onStorySaveResult handling to bridge, and renamed STORY_SAVE_ST…
mzorz Sep 25, 2020
b305a9d
checking for matches of mediaId in mediaFiles while saving to send s…
mzorz Sep 28, 2020
407b2d1
added mediaModelCreated() method to the bridge, so a new ID can be as…
mzorz Sep 28, 2020
269cc91
mediaId should always be a string in mediaFiles so, converting to avo…
mzorz Sep 29, 2020
5ce5e5c
removed commented code
mzorz Sep 29, 2020
e83c8c8
updated documentation
mzorz Sep 30, 2020
42288a5
added missing implementation of method storySaveSync() in demo app
mzorz Oct 1, 2020
0213a1f
Merge branch 'try/jetpack-stories-block-mobile' into try/jetpack-stor…
mzorz Oct 1, 2020
5d385b5
fixed prettier warning
mzorz Oct 1, 2020
1934b2d
Merge branch 'try/jetpack-stories-block-mobile' into try/jetpack-stor…
mzorz Oct 9, 2020
6cc55f4
renames for generic media files collection block and BlockMediaUpdate…
mzorz Oct 10, 2020
61877c2
referencing the right props method in finishMediaSaveWithFailure
mzorz Oct 10, 2020
1ab42cf
mistaken renames of parameters in bridge methods
mzorz Oct 10, 2020
4182bdd
renamed more abstract/generic method names requestMediaFilesEditorLoad
mzorz Oct 10, 2020
4fbc17d
removed extra whtie space
mzorz Oct 11, 2020
3592ff0
renamed argument type
mzorz Oct 11, 2020
f1e4782
renamed event paramter name to easier to understand 'success' boolean…
mzorz Oct 11, 2020
ee45b07
added cancel and retry bridge methods specific for mediaFiles collect…
mzorz Oct 12, 2020
053a168
added requestMediaFilesSaveCancelDialog bridge method
mzorz Oct 12, 2020
7a18e56
renamed bridge method mediaModelCreatedForFile for more general purpo…
mzorz Oct 13, 2020
d72efb8
fixed merge conflicts
mzorz Oct 16, 2020
a2318de
added jetpack node_modules folder to cleanup step in JSbundle buildin…
mzorz Oct 17, 2020
e37a885
Merge branch 'try/jetpack-stories-block-mobile' into try/jetpack-stor…
mzorz Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native-bridge/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ If they are changed, the isBundleUpToDate flag is switched to false. That flag i
}
}

def nodeModulesFolders = ["$mobileGutenbergRootDir/node_modules", "$mobileGutenbergRootDir/gutenberg/node_modules"] as String[]
def nodeModulesFolders = ["$mobileGutenbergRootDir/node_modules", "$mobileGutenbergRootDir/gutenberg/node_modules", "$mobileGutenbergRootDir/jetpack/node_modules"] as String[]
task cleanupNodeModulesFolders(type: Delete) {
doFirst {
println "Deleting node_modules folders"
Expand Down