Try useAnimate for all <Animate /> cases, lightening the React tree #26201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
|
Size Change: -136 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
ellatrix
commented
Nov 4, 2020
| @@ -27,9 +27,7 @@ function ComplementaryAreaSlot( { scope, ...props } ) { | |||
| function ComplementaryAreaFill( { scope, children, className } ) { | |||
| return ( | |||
| <Fill name={ `ComplementaryArea/${ scope }` }> | |||
| <Animate type="slide-in" options={ { origin: 'left' } }> | |||
| { () => <div className={ className }>{ children }</div> } | |||
There was a problem hiding this comment.
Class isn't used, so removing.
|
We can let it sit for a while as unstable and decide later. Not sure what the future is for these animation classes. Cc @jasmussen. In the mean time this makes some components less complex, especially the popover component. |
|
Thank you Ella. Also CC: @ItsJonQ |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This hook was introduces (as unstable) in #26063, but it seems good to have for all instances where
<Animate />is currently used. There's no good reason for this to be a component.Should we mark the hooks stable? Should we deprecate the component?
Should it remain in the
componentspackage? I think it still makes sense here since it provides a class, and it's mostly used in the package.How has this been tested?
Screenshots
Types of changes
Checklist: