Site Editor: Fix height of Navigation panel and make it scrollable #26187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
requested review from
mattwiebe,
vindl,
Copons,
jeyip,
noahtallen and
Addison-Stavlo
|
Size Change: +95 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
Copons
reviewed
Oct 16, 2020
packages/edit-site/src/components/navigation-sidebar/navigation-panel/style.scss
Outdated
Show resolved
Hide resolved
david-szabo97
force-pushed
the
update/navigation-panel-animations
branch
2 times, most recently
from
83b0517 to
bf82194
Compare
jeyip
force-pushed
the
update/navigation-panel-animations
branch
from
bf82194 to
bd29228
Compare
Copons
force-pushed
the
update/navigation-panel-animations
branch
from
bd29228 to
ce55683
Compare
david-szabo97
force-pushed
the
fix/navigation-panel-height-and-scroll
branch
from
3e4091c to
1f1b890
Compare
|
Rebased, ready for review again 🙂 |
Copons
requested changes
Oct 21, 2020
There was a problem hiding this comment.
It doesn't seem to work as expected to me. 🤔
| Tall Screen | Medium Screen | Short Screen (scrolled top) | Short Screen (scrolled bottom) |
|---|---|---|---|
 |
 |
 |
 |
| ✅ No scrollbar | ❌ No scrollbar ❌ Last element covered by footer |
✅ Scrollbar ❌ Scrollbar ends under footer ❌ Last element covered by footer |
(Same) |
|
Uggggh. Thanks for noticing that! Fixed it. Only tested in Chrome for now. I'll test in the other browsers tomorrow. |
Copons
approved these changes
Oct 21, 2020
david-szabo97
force-pushed
the
fix/navigation-panel-height-and-scroll
branch
from
f2dfb9d to
0d2e9c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26120
Description
Add a scroll container and makes sure the site title stick to the top. Also subtracts the footer's height from the navigation panel's height so it doesn't "go below" the footer.
How has this been tested?
Screenshots
Checklist: