First pass at using the new sidebars and widget endpoints. #26086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyBJacobs
requested review from
draganescu,
adamziel,
spacedmonkey and
noisysocks
TimothyBJacobs
requested review from
kevin940726,
nerrad,
talldan,
tellthemachines and
youknowriad
as code owners
|
PHPUnit tests failures are unrelated see, #26085. |
|
The first time I tried to save after switching to this branch and building I got |
TimothyBJacobs
force-pushed
the
update/use-widgets-endpoint
branch
from
649d777 to
a53126f
Compare
This happens when the response returned when trying to create an endpoint doesn't return a valid response. This happened in particular because RSGW generates a fatal error when calling I've added a specific error message when saving a widget fails due to this reason, |
TimothyBJacobs
force-pushed
the
update/use-widgets-endpoint
branch
2 times, most recently
from
0e4f26b to
26549c1
Compare
TimothyBJacobs
changed the base branch from
master
to
update/data-layer-batch-requests-use-state
Works off of WordPress#26205.
We need to get the full list of widget ids from the client, we can't use the returned widget ids from the batch because not all widgets will be dirty. Also implements basic error handling for when the batch fails. A snackbar is added with the names of the widgets that failed to save. We also now propagate a dummy error to the apiFetch callers for the requests that didn't have a validation error, but need something to short circuit their handling.
adamziel
force-pushed
the
update/use-widgets-endpoint
branch
from
c38f6b6 to
8eced9b
Compare
TimothyBJacobs
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
mkaz and
Soean
as code owners
adamziel
force-pushed
the
update/data-layer-batch-requests-use-state
branch
from
e36d90e to
3c3b2e7
Compare
…/use-widgets-endpoint
|
Merging with base branch, let's consider this as a single PR. |
adamziel
merged commit 1d80d48
into
WordPress:update/data-layer-batch-requests-use-state
adamziel
added a commit
that referenced
this pull request
Oct 19, 2020
* Draft batch-processing module * committing/rudimentary API_FETCH integration * Make batch processing functional! * Roll back integration changes * Cleanup package.json * Update package-lock.json * Update terminology * yield from commitTransaction * Correct yield from * Move the comment where it belongs * First pass at enqueueItemAndWaitForResults. * Draft batch-processing module * committing/rudimentary API_FETCH integration * Make batch processing functional! * Roll back integration changes * Cleanup package.json * Update package-lock.json * Update terminology * yield from commitTransaction * Correct yield from * Move the comment where it belongs * update package-lock.json * First pass at using the new sidebars and widget endpoints. (#26086) * Draft batch-processing module * committing/rudimentary API_FETCH integration * Make batch processing functional! * Roll back integration changes * Cleanup package.json * Update package-lock.json * Update terminology * yield from commitTransaction * Correct yield from * Move the comment where it belongs * First pass at enqueueItemAndWaitForResults. * First pass at using the new sidebars and widget endpoints. * Add test for saving multiple widgets in a row * Generate better error message when creating fails * Add basic batch integration. Works off of #26205. * Allow mixing HTTP methods in a batch. * Fix disappearing data, add basic error handling. We need to get the full list of widget ids from the client, we can't use the returned widget ids from the batch because not all widgets will be dirty. Also implements basic error handling for when the batch fails. A snackbar is added with the names of the widgets that failed to save. We also now propagate a dummy error to the apiFetch callers for the requests that didn't have a validation error, but need something to short circuit their handling. * yield from the widget area saving. * Move batch-processing into edit-widgets package Co-authored-by: Adam Zieliński <[email protected]> * remove separate batch-processing package * Update batch processing tests * Resolve batch errors in a safe, well-ordered way * Fix unit tests * Wire progress indicator to specific widgets * Fix authorship after merge/rebase (1/2) * Fix authorship after merge/rebase (2/2) * Don't mark the method property as required. We don't evaluate nested defaults yet, so this caused errors. * Allow updating widgets without including the id_base or number. * Don't start GET /wp/v2/widgets?per_page=-1 if there are batch requests already in progress * Process newWidgetClientIds in correct order * Fix package.json * remove batch-processing package Co-authored-by: Timothy Jacobs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the new sidebars and widget endpoints introduced in #25958.
How has this been tested?
Manual testing, PHPUnit testing.
Types of changes
Refactoring.
Right now the saves are all separate requests. This is blocked on #26024.
Checklist: