Add no results placeholder in Query block #25984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Full Site Editing
[Block] Query Loop
|
Size Change: +25 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
Eventually this should be customizable with an inner-blocks area. |
mtias
reviewed
Oct 9, 2020
| @@ -97,6 +98,10 @@ export default function QueryLoopEdit( { | |||
| ); | |||
| const blockProps = useBlockProps(); | |||
|
|
|||
| if ( ! posts?.length ) { | |||
| return <div { ...blockProps }> { __( 'No results found.' ) }</div>; | |||
There was a problem hiding this comment.
Why do we need the blockProps in the div? Also could we just turn it into a p tag for now?
There was a problem hiding this comment.
This is the block wrapper. Every block needs at least one element that can act as the block wrapper with all events and attributes attached, otherwise it wouldn't be possible to interact with it and have no toolbar. This block is a light block, so it's responsible for rendering its own wrapper. The block cannot be just a string.
There was a problem hiding this comment.
But it would be a p tag, sure. It can be any tag or component.
There was a problem hiding this comment.
We need it to mark it as a block. If it was just a string it wouldn't be selectable and interactive in general. I will make it a p.
There was a problem hiding this comment.
Got it, I didn't review the broader context :)
mtias
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds to Query block a simple for now placeholder, when no results are found. This is needed because if no results are found and no other blocks exist, it shows nothing. Better design if needed will be in a follow up.