Site Editor: Add missing localization to the templates sidebar #25897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +59 B (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Oct 7, 2020
| title: 'Default (Page)', | ||
| description: 'Displays the content of a single page', | ||
| title: __( 'Page' ), | ||
| description: __( 'Single page template' ), |
There was a problem hiding this comment.
Suggested change
| description: __( 'Single page template' ), | |
| description: __( 'Single-page template' ), |
Normally it's a stylistic nit pick (as not all styles in English follow this usage of hyphens), but in the context of i18n I believe this will help make the string less ambiguous for translators and therefore less likely to need _x or // translators :)
There was a problem hiding this comment.
It makes sense 🤔
I do have a slight personal preference for the non-hyphenated version, though.
How about "Template for single pages/posts"?
It would also be consistent with the singular description ("Default template for both single posts and pages").
(Also, I'm going to update the titles of page and single to "Single Page" and "Single Post", which was my intention already, but it slipped through the commit)
There was a problem hiding this comment.
How about "Template for single pages/posts"?
No strong opinion, that works too. :) Though I'd drop the slash and go with
Suggested change
| description: __( 'Single page template' ), | |
| description: __( 'Template for single pages and posts' ), |
There was a problem hiding this comment.
Ah yeah, sorry, I meant two separate strings: "Template for single pages" and "Template for single posts". 🙂
vindl
approved these changes
Oct 7, 2020
packages/edit-site/src/components/left-sidebar/navigation-panel/constants.js
Outdated
Show resolved
Hide resolved
david-szabo97
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When approving #25739 I've completely failed to check for i18n.
Here I've localized all strings contained in the Site Editor's template sidebar, adding contexts where I felt it was needed.
I've also reworded the default templates (and reordered them, and removed a couple that aren't really default) names and description to match the Template Hierarchy docs as closely as possible.
Hopefully I haven't missed anything!
How has this been tested?
In the Site Editor.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: