Unify help description text styling #25852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2020 08:57
Remove help text styling and iterate to bring in no italics and also unify with other help text already in place.
Removes italics and brings in similar styling for help, desciptive text.
karmatosed
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
|
Size Change: +1.66 kB (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
|
Before:
After:
This seems more legible to me than the italic font. I'm a fan. |
jasmussen
reviewed
Oct 7, 2020
| @@ -17,6 +17,8 @@ | |||
|
|
|||
| .components-base-control__help { | |||
| margin-top: -$grid-unit-10; | |||
| font-style: italic; | |||
| font-size: $default-font-size - 1px; | |||
There was a problem hiding this comment.
I'd create a new $helptext-font-size and reference that directly.
There was a problem hiding this comment.
Oh, that's a great idea, spinning up those changes now! Thanks for review.
| @@ -48,7 +48,9 @@ | |||
| } | |||
|
|
|||
| .components-form-token-field__help { | |||
| font-style: italic; | |||
| font-size: $default-font-size - 1px; | |||
There was a problem hiding this comment.
Should this be using the new $helptext-font-size as well?
There was a problem hiding this comment.
Ah yes! I think I also found another instance. @aaroncampbell would you be able to do another code review, please? Fingers crossed I've caught all those pesky variables now. Thanks so much.
aaroncampbell
approved these changes
Oct 7, 2020
|
I almost wonder if there should be a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in the toolbar styling across help classes and also to the base help class. In my work on options I am currently having to work around the italic styling, so this will avoid me having to do that by fixing the base style. It also brings in the style to the sidebar. Linked to issue #25851.
Visuals of PR in action
Feedback
I am generally looking for code review on this PR and also looking for design feedback, specifically around where this could also be iterated if anything was missed class wise or other aspects.