Include edit-widgets php files in build #25792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.18 MB ℹ️ View Unchanged
|
talldan
requested review from
tellthemachines,
kevin940726,
noisysocks,
adamziel and
draganescu
talldan
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Thanks so much for the fix!
Lets merge this, though I also wonder if it'd make sense to the move the legacy-widget block into the block library given it's already a dependency of the edit-widget screen.
Nothing stopping that change from happening after this PR is merged, so I think we should do this first, and address that later.
edit: I see now this was specifically moved from block-library in #25371, though I'm still not convinced that was really necessary.
adamziel
pushed a commit
that referenced
this pull request
Oct 7, 2020
Merged
draganescu
pushed a commit
that referenced
this pull request
Oct 7, 2020
* Include edit-widgets php files in build (#25792) * Fix PHP warining in widget utils controller (#25797) * Fix PHP warning in WP_REST_Widget_Utils_Controller The `WP_REST_Widget_Utils_Controller::is_valid_widget` method needs to be public in order to be accessible as a callback (since it's being called from outside the class, via `call_user_func`). This commit fixes the warning by changing the method's visibility from `private` to `public`. * Ammend the inline documentation. Add `* @access public` * [Widgets Editor] Fix insertion point in widget areas (#25727) * Move hooks inside the newly created Interface component * Fix insertion at the top of the widget area * Fix widget insertion from sidebar block library by using a declared insertionPoint prop (#25763) * Fix widget insertion from sidebar block library by using a declared insertionPoint prop * Add comments * Optimize by avoiding `getEntityRecord` call unless needed Co-authored-by: Daniel Richards <[email protected]> * Initialize the state before rendering widgets editor (#25736) * Initialize the state before rendering widgets editor * Replace empty div with null * Document persistStubPost * Document persistStubPost further * Bump version to 9.1.1 * Update changelog * Fix spaces in changelog.txt * Adjust spaces in changelog.txt * Fix link formatting in the changelog Co-authored-by: Jon Surrell <[email protected]> Co-authored-by: David Biňovec <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Daniel Richards <[email protected]>
This was referenced Oct 7, 2020
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The plugin build is currently broken after #25371 which moved the
core/legacy-widgetblock to theedit-widgetspackage. This directory now includesblock.jsonandindex.phpfiles which should be included in the plugin build just likeblock-library.This causes PHP fatal errors in the widget block editor like:
Props to @david-binda for spotting missing files and fatals.
How has this been tested?
Install the 9.1.0 plugin from the plugin repository and the PHP fatals can be observed when visiting the new Widgets block editor.
Confirm that the necessary files were missing from v9.1.0:
In this branch
Types of changes
Bug fix (non-breaking change which fixes an issue)
Fix missing files from the plugin build.
Checklist: