Mark the color support flag as stable #25694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Block API
youknowriad
requested review from
ajitbohra,
ellatrix,
Soean,
spacedmonkey,
talldan and
TimothyBJacobs
as code owners
youknowriad
changed the title
|
Size Change: -44 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
ItsJonQ
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
🚀 from me! The color settings continue to work for the various blocks as expected 👍 .
Thanks @youknowriad !
aristath
approved these changes
Sep 30, 2020
This was referenced Oct 1, 2020
tellthemachines
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, third-party block authors using the "light block wrapper" will be able to add colors support with a single line of code to their custom blocks. In follow-up PRs, we'll be stabilizing other support flags too.
I've also renamed "linkColor" key to just "link" to avoid the redunduncy.
link color remains experimental though because it relies on Global styles and still uses an experimental theme flag.