-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectControl: Fix labelPosition #25427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsJonQ
added
[Type] Bug
An existing feature does not function as intended
[Package] Components
/packages/components
labels
Sep 17, 2020
ItsJonQ
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
September 17, 2020 17:42
Size Change: +13 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @ItsJonQ 👍 ! Thanks!
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Components
/packages/components
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes the default
labelPosition
for theSelectControl
(defaulting totop
). ThelabelPosition
component API is the same as that fromInputControl
.README documentation has been updated for the various controls to indicate
labelPosition
.Thanks to @jorgefilipecosta for spotting this one!
How has this been tested?
Tested locally in Storybook
npm run storybook:dev
SelectControl
story (http://localhost:50240/?path=/story/components-selectcontrol--default)labelPosition
knob (below)Checklist: