-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Component: Semantically create nested lists #25280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psealock
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
September 14, 2020 01:24
psealock
added
the
[Feature] Navigation Component
A navigational waterfall component for hierarchy of items.
label
Sep 14, 2020
Size Change: +3 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
Copons
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was so simple! ✨
Thanks for taking care of this @psealock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25248
Description
Semantically render nested lists.
NavigationMenu
accepts bothNavigationGroup
andNavigationItem
(or any combination thereof) and will always render correct HTML structure:See more on nesting lists here: https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/HTML_text_fundamentals#Lists
#25248 hypothesises HTML manipulation may be well suited to automation once a way to analyze
Navigation
children. I don't think that will be required because these changes ensure a correct structure.How has this been tested?
npm run storybook:dev
.Screenshots
Types of changes
Changes make rendering a
ul
element unneeded. Technically this is breaking, but Navigation code is unreleased and behind__experimental
flag.Checklist: