Limit the block slash inserter to 9 items and show most used by default #25113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Inserter
|
Size Change: +2.92 kB (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
I think this might cause some problems, since there isn't even a link like quick inserter to browse all and a user might want to search something that is not in top 6. There had been some issues about limiting to 6 in quick inserter as well in the past.. |
|
I pushed 0cc4970, needed to slice the list if one of the |
ntsekouras
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
I still have my concerns about limiting to 6 results, as there had been some issues about limiting to 6 in quick inserter as well, but there the browse all button exists.
Code looks good though and we can alternatively revisit, if any new issues about this occur.
Good catch with the variations too 💯
|
6 seems a bit low for the slash inserter indeed, let's make it 9 to start with. |
mcsf
changed the title
|
Thanks! |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits the block autocompleter to 6 items and default to the most used blocks by default.