Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated __unstableMigrate function #25023

Conversation

sbappan
Copy link

@sbappan sbappan commented Sep 2, 2020

Description

This PR removes the deprecated __unstableMigrate function code and resolves #24931

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@youknowriad
Copy link
Contributor

@noisysocks I believe you're one of the last persons who touched this, is it safe to remove now?

@noisysocks
Copy link
Member

Looks good. We'll need to remove the code from Core that calls __unstableMigrate. Can you open a ticket on Trac with a patch that does this, @sbappan?

@youknowriad
Copy link
Contributor

So it seems if we merge this PR, The plugin won't support 5.4 and 5.5, am I right? So maybe we should add a comment instead of removing.

@noisysocks
Copy link
Member

So it seems if we merge this PR, The plugin won't support 5.4 and 5.5, am I right?

Ah, correct. We can't remove this code until our Requires at least is 5.6. We should proceed with opening and committing a Trac ticket that removes three this is called right now though.

@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality Backwards Compatibility Issues or PRs that impact backwards compatability labels Nov 8, 2020
Base automatically changed from master to trunk March 1, 2021 15:44
@Mamaduka
Copy link
Member

The plugin now requires WP 5.6 or higher.

@t-hamano
Copy link
Contributor

The __unstableMigrate function appears to have been properly removed by #39795.
Should we close this PR?

@Mamaduka
Copy link
Member

@t-hamano, you're right. We can close this PR.

@Mamaduka Mamaduka closed this Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated __unstableMigrate function
6 participants