Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Correct multiple sliders spacings #25017

Merged
merged 2 commits into from
Sep 2, 2020
Merged

[RNMobile] Correct multiple sliders spacings #25017

merged 2 commits into from
Sep 2, 2020

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Sep 2, 2020 •
edited
Loading

Ref to gutenberg-mobile: wordpress-mobile/gutenberg-mobile#2590

Description

Correct spacing in multiple sliders in Columns settings.

How has this been tested?

  1. Open draft post
  2. Add Columns block
  3. Press Cancel on block variation
  4. Open columns settings
  5. Expect correct spacings

Check also settings in other blocks (Cover, Button, Image) if looks properly!

Screenshots

ios android
Screenshot 2020-09-02 at 16 28 16

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@lukewalczak lukewalczak self-assigned this Sep 2, 2020
@lukewalczak lukewalczak requested a review from dratwas September 2, 2020 14:27
@lukewalczak lukewalczak added [Feature] Block settings menu The block settings screen Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Sep 2, 2020
This was referenced Sep 2, 2020
Merged
Closed
@github-actions
Copy link

github-actions bot commented Sep 2, 2020

Size Change: 0 B

Total Size: 1.17 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.41 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.99 kB 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-editor/index.js 128 kB 0 B
build/block-editor/style-rtl.css 10.8 kB 0 B
build/block-editor/style.css 10.8 kB 0 B
build/block-library/editor-rtl.css 8.55 kB 0 B
build/block-library/editor.css 8.55 kB 0 B
build/block-library/index.js 137 kB 0 B
build/block-library/style-rtl.css 7.47 kB 0 B
build/block-library/style.css 7.47 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 742 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.7 kB 0 B
build/components/index.js 200 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.67 kB 0 B
build/core-data/index.js 12.3 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.55 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.48 kB 0 B
build/edit-navigation/index.js 11.7 kB 0 B
build/edit-navigation/style-rtl.css 1.16 kB 0 B
build/edit-navigation/style.css 1.16 kB 0 B
build/edit-post/index.js 305 kB 0 B
build/edit-post/style-rtl.css 6.26 kB 0 B
build/edit-post/style.css 6.24 kB 0 B
build/edit-site/index.js 17 kB 0 B
build/edit-site/style-rtl.css 3.06 kB 0 B
build/edit-site/style.css 3.06 kB 0 B
build/edit-widgets/index.js 12 kB 0 B
build/edit-widgets/style-rtl.css 2.46 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.4 kB 0 B
build/editor/style-rtl.css 3.81 kB 0 B
build/editor/style.css 3.81 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.71 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@cameronvoell cameronvoell self-requested a review September 2, 2020 19:32
cameronvoell
cameronvoell approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sliders look good on columns on Android and iOS. Cover, Button, Image look good as well, thanks for the fix.

@cameronvoell cameronvoell merged commit f7d3945 into master Sep 2, 2020
@cameronvoell cameronvoell deleted the rnmobile/correct-multiple-sliders-spacings branch September 2, 2020 19:33
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 2, 2020
cameronvoell pushed a commit that referenced this pull request Sep 2, 2020
@lukewalczak @cameronvoell
[RNMobile] Correct multiple sliders spacings (#25017)
7f07404 
* Correct spacings

* Correct cellContainerStyle
cameronvoell added a commit that referenced this pull request Sep 4, 2020
@cameronvoell @lukewalczak
[RNMobile] Merge 1.36.0 release to master (#25081)
9e69214 
* Release script: Update react-native-editor version to 1.36.0

* Release script: Update with changes from 'npm run core preios'

* [RNMobile] Correct multiple sliders spacings (#25017)

* Correct spacings

* Correct cellContainerStyle

* Updated changelog

Co-authored-by: Luke Walczak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

@dratwas dratwas Awaiting requested review from dratwas

Assignees

@lukewalczak lukewalczak

Labels
[Feature] Block settings menu The block settings screen Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewalczak @cameronvoell