Navigation Component: Update docs #24880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psealock
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
psealock
added
the
[Feature] Navigation Component
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
joshuatf
approved these changes
Aug 28, 2020
| - Type: `string|Number` | ||
| - Required: No | ||
|
|
||
| Specify a menu item's parent id. |
There was a problem hiding this comment.
Maybe note that root will get added as the menu item's parent if none is provided.
|
|
||
| An array of config objects for each menu item. | ||
|
|
||
| ### `initial` | ||
| Config objects can be represented |
There was a problem hiding this comment.
Missing onClick param option.
Co-authored-by: Joshua T Flowers <[email protected]>
Co-authored-by: Joshua T Flowers <[email protected]>
Co-authored-by: Joshua T Flowers <[email protected]>
psealock
added a commit
that referenced
this pull request
Aug 31, 2020
* Update readme * first attempt to define data * Update packages/components/src/navigation/README.md Co-authored-by: Joshua T Flowers <[email protected]> * Update packages/components/src/navigation/README.md Co-authored-by: Joshua T Flowers <[email protected]> * better declaration * Add onClick prop * note parent default * Update packages/components/src/navigation/README.md Co-authored-by: Joshua T Flowers <[email protected]> Co-authored-by: Joshua T Flowers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24700
Description
Update the navigation component's README and other docs.