Create unstable selectors for getting all controlled inner blocks #24835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Feature] Nested / Inner Blocks
noahtallen
requested review from
ajitbohra,
chrisvanpatten,
ellatrix and
mkaz
as code owners
6 tasks
|
Size Change: -21 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
noahtallen
requested review from
vindl,
Addison-Stavlo,
jeyip,
ockham,
Copons and
david-szabo97
mtias
reviewed
Aug 27, 2020
| } = select( 'core/block-editor' ); | ||
| const selectedBlockClientId = getSelectedBlockClientId(); | ||
| return { | ||
| rootBlocks: getBlocks( '', { includeControlledInnerBlocks: true } ), | ||
| rootBlocks: __unstableGetBlocksWithControlledInnerBlocks( '' ), |
There was a problem hiding this comment.
Would something like getBlocksTree be more clear / succinct? Not sure "with controlled inner blocks" clarifies much at a glance.
There was a problem hiding this comment.
Yeah, I think that would be a better approach. Indicating that this is "all blocks in the tree of the editor," rather than the blocks attached to a specific block parent. I was struggling over the naming here, so thanks for the suggestion!
noahtallen
force-pushed
the
try/move-get-block-selectors-to-unstable
branch
from
0250907 to
1ffddc7
Compare
youknowriad
reviewed
Aug 31, 2020
youknowriad
approved these changes
Aug 31, 2020
youknowriad
force-pushed
the
try/move-get-block-selectors-to-unstable
branch
from
fa6109b to
56eec24
Compare
I was thinking about how we might do this, but the consumer needed to be able to get an array of blocks with Thanks for fixing the cache key! |
Not that important anyway, I was just thinking maybe an inline function for getBlock inside getBlockTree could work there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24690
Description
Based on discussion here and in slack, this PR moves the code which gets blocks including controlled inner blocks to separate unstable selectors. Previously, this behaviour was accessible via parameters to the normal getBlock/getBlocks selectors.
This changes nothing functionally, just cleans up the API for getBlock/getBlocks.
How has this been tested?
locally, in edit site.
Screenshots
behaviour of block navigation is the same:
Types of changes
Code quality.
Checklist: