-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Variations: Center-align the variation buttons #24547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
added
[Type] Bug
An existing feature does not function as intended
CSS Styling
Related to editor and front end styles, CSS-specific issues.
[Feature] Block Variations
Block variations, including introducing new variations and variations as a feature
labels
Aug 13, 2020
Size Change: +4 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
noahtallen
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Just to be clear: since this does not only affect the Site Editor experiment, I'm waiting for more reviews before merging. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CSS Styling
Related to editor and front end styles, CSS-specific issues.
[Feature] Block Variations
Block variations, including introducing new variations and variations as a feature
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The variation button is left-aligned, while its label is centered.
When the label is wider than the button, it appears misaligned.
This PR centers the button as well, and moves the margins from button and label to the list item itself in order to retain the same spacing between variations.
How has this been tested?
Tested with the Columns block, by manually replacing the variations names with their descriptions.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: