-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression bug for category select in QueryControls component #24516
Fix regression bug for category select in QueryControls component #24516
Conversation
Just ran into this issue with a block that uses this component. |
@youknowriad thoughts on this? It's a breaking change. Is there guidance here for if/when this will be merged and/or if the recommended path is something else? |
I'm not sure I follow everything here but @draganescu should know more as the original PR author. I added the corresponding labels for Core backports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow this got away in the PR that should have fixed everything. Thanks @gchtr !
was this fixed for 5.5.1? Because I still have the same issue |
@faia20 Do you have the Gutenberg plugin enabled or disabled? |
|
that's the reason, the fix didn't make it yet to the plugin, if you disable the plugin, it should work. |
you're right! I've disabled and it's working! |
Description
In #23419, backwards compatibility with
<QueryControls>
was fixed. However, the<CategorySelect>
still misses theonChange
property, causing an error when a category is selected from the dropdown:How has this been tested?
I manually tested the fix and I ran
npm run test
locally.Types of changes
Bug fix.
Checklist: