Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Component: Remove internal state #24255

Closed
wants to merge 1 commit into from
Closed

Navigation Component: Remove internal state #24255

wants to merge 1 commit into from

Conversation

psealock
Copy link
Contributor

@psealock psealock commented Jul 29, 2020 •
edited
Loading

Description

Trac ticket: https://core.trac.wordpress.org/ticket/47012

Remove Navigation component's internal state. The component will be purely presentational and react only changes in supplied props.

Screenshots

Screen Shot 2020-07-24 at 1 05 50 PM

Test instructions

  1. npm run storybook:dev
  2. Components > Navigation.
  3. Ensure the component navigates as it previously has.
  4. Try the new links on the right to see the component react to outside navigation.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@psealock psealock added the [Feature] Navigation Component A navigational waterfall component for hierarchy of items. label Jul 29, 2020
@psealock psealock mentioned this pull request Jul 29, 2020
Closed
4 tasks
@psealock psealock changed the title Initial working tree display Navigation Component: Remove internal state Jul 29, 2020
@psealock psealock mentioned this pull request Jul 29, 2020
Closed
@psealock
Copy link
Contributor Author

Closing in favor of #24266

@psealock psealock closed this Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@youknowriad youknowriad Awaiting requested review from youknowriad youknowriad is a code owner

Assignees
No one assigned
Labels
[Feature] Navigation Component A navigational waterfall component for hierarchy of items.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@psealock