Add option to show icon labels.

[tellthemachines]

Description

Addresses #10524 and #15311
Adds an option in the Options modal to show labels for the editor UI icons.

No labels have been added yet; this is just the option toggle for the post editor. Further PRs will address adding the actual labels in each area where they are needed: the top toolbar and the block toolbar.

This and the upcoming PRs for the labels will replace #15830 as that PR has too many conflicts to be salvageable.

How has this been tested?

Tested in browser.

Screenshots

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[tellthemachines]

As it stands, this option only applies to the post editor. But this is a setting that will also be useful in the site editor; is there a way we could make it apply in both places? It would be awkward to have an identical setting for each screen.

[github-actions]

Size Change: +31 B (0%)

Total Size: 1.17 MB

Filename	Size	Change
build/edit-post/index.js	304 kB	+31 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
build/a11y/index.js	1.14 kB	0 B
build/annotations/index.js	3.67 kB	0 B
build/api-fetch/index.js	3.44 kB	0 B
build/autop/index.js	2.82 kB	0 B
build/blob/index.js	620 B	0 B
build/block-directory/index.js	7.99 kB	0 B
build/block-directory/style-rtl.css	953 B	0 B
build/block-directory/style.css	952 B	0 B
build/block-editor/index.js	126 kB	0 B
build/block-editor/style-rtl.css	10.8 kB	0 B
build/block-editor/style.css	10.8 kB	0 B
build/block-library/editor-rtl.css	8.55 kB	0 B
build/block-library/editor.css	8.55 kB	0 B
build/block-library/index.js	136 kB	0 B
build/block-library/style-rtl.css	7.47 kB	0 B
build/block-library/style.css	7.47 kB	0 B
build/block-library/theme-rtl.css	741 B	0 B
build/block-library/theme.css	742 B	0 B
build/block-serialization-default-parser/index.js	1.88 kB	0 B
build/block-serialization-spec-parser/index.js	3.1 kB	0 B
build/blocks/index.js	47.7 kB	0 B
build/components/index.js	200 kB	0 B
build/components/style-rtl.css	15.5 kB	0 B
build/components/style.css	15.5 kB	0 B
build/compose/index.js	9.67 kB	0 B
build/core-data/index.js	12.3 kB	0 B
build/data-controls/index.js	1.29 kB	0 B
build/data/index.js	8.55 kB	0 B
build/date/index.js	5.38 kB	0 B
build/deprecated/index.js	772 B	0 B
build/dom-ready/index.js	568 B	0 B
build/dom/index.js	4.48 kB	0 B
build/edit-navigation/index.js	11.6 kB	0 B
build/edit-navigation/style-rtl.css	1.16 kB	0 B
build/edit-navigation/style.css	1.16 kB	0 B
build/edit-post/style-rtl.css	5.61 kB	0 B
build/edit-post/style.css	5.61 kB	0 B
build/edit-site/index.js	17 kB	0 B
build/edit-site/style-rtl.css	3.06 kB	0 B
build/edit-site/style.css	3.06 kB	0 B
build/edit-widgets/index.js	12 kB	0 B
build/edit-widgets/style-rtl.css	2.46 kB	0 B
build/edit-widgets/style.css	2.45 kB	0 B
build/editor/editor-styles-rtl.css	492 B	0 B
build/editor/editor-styles.css	493 B	0 B
build/editor/index.js	45.3 kB	0 B
build/editor/style-rtl.css	3.81 kB	0 B
build/editor/style.css	3.81 kB	0 B
build/element/index.js	4.65 kB	0 B
build/escape-html/index.js	733 B	0 B
build/format-library/index.js	7.71 kB	0 B
build/format-library/style-rtl.css	547 B	0 B
build/format-library/style.css	548 B	0 B
build/hooks/index.js	2.13 kB	0 B
build/html-entities/index.js	621 B	0 B
build/i18n/index.js	3.57 kB	0 B
build/is-shallow-equal/index.js	710 B	0 B
build/keyboard-shortcuts/index.js	2.52 kB	0 B
build/keycodes/index.js	1.94 kB	0 B
build/list-reusable-blocks/index.js	3.12 kB	0 B
build/list-reusable-blocks/style-rtl.css	476 B	0 B
build/list-reusable-blocks/style.css	476 B	0 B
build/media-utils/index.js	5.32 kB	0 B
build/notices/index.js	1.79 kB	0 B
build/nux/index.js	3.4 kB	0 B
build/nux/style-rtl.css	671 B	0 B
build/nux/style.css	668 B	0 B
build/plugins/index.js	2.56 kB	0 B
build/primitives/index.js	1.41 kB	0 B
build/priority-queue/index.js	789 B	0 B
build/redux-routine/index.js	2.85 kB	0 B
build/rich-text/index.js	13.9 kB	0 B
build/server-side-render/index.js	2.77 kB	0 B
build/shortcode/index.js	1.7 kB	0 B
build/token-list/index.js	1.27 kB	0 B
build/url/index.js	4.06 kB	0 B
build/viewport/index.js	1.85 kB	0 B
build/warning/index.js	1.14 kB	0 B
build/wordcount/index.js	1.17 kB	0 B

_{compressed-size-action}

[paaljoachim]

The category inside Options "Icon Labels" could perhaps instead be named "Labels" as it would make it possible to later on add if needed additional label options inside this category.

[ZebulanStanphill]

I'd change the option from "Show Icon Labels" to "Show button text labels". (Note capitalization.)

[noisysocks]

Code looks great 👍, but I don't think we should add this option to the plugin before we have anything that uses it? It would be confusing, I think, to see this setting, click it, and not see anything happen.

[tellthemachines]

Code looks great 👍, but I don't think we should add this option to the plugin before we have anything that uses it? It would be confusing, I think, to see this setting, click it, and not see anything happen.

I agree, and the PR that adds this to the toolbar is coming up Very Soon. The reason I did it this way is the original PR to add this functionality floundered because it was a huge changeset and conflicts kept popping up with every passing day, so I thought it might be easier to divide into even smaller chunks.

[tellthemachines]

Aaaand #24304 has now materialised with all the labels for the top toolbar 😄

[draganescu]

#24304 is approved now and this makes sense 👍