Remove Link settings PanelBody from Button block #24070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes Link settings, though now there's no way to add rel
|
Size Change: -71 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
That would need to be handled first before this can be merged. An interim solution might be to keep the Link Settings panel, but just remove the Open In New Tab toggle. |
|
Fixed via #29664. |
|
For context, the rel attribute was moved to the advanced settings (still in the sidebar); and Open in New Tab Toggle is still accessible in the Link UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #23768 by removing the duplicate Link Settings PanelBody, following the pattern of removing duplicate methods for the same actions, as seen in the Heading block #20246.
One side-effect (that we'll need to address) is that the Link Settings PanelBody allowed for setting the
relattribute. I suggest that this is added to the URLPicker within the Button block.How has this been tested?
WP 5.5 RC
Screenshots
Types of changes
Removing duplicate UI.
Checklist: