Try running the performance tests as a Github action. #23818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
youknowriad
force-pushed
the
try/run-perf-tests-per-pr
branch
2 times, most recently
from
87eca6f to
9fc1f6a
Compare
youknowriad
force-pushed
the
try/run-perf-tests-per-pr
branch
from
9fc1f6a to
3d442f4
Compare
youknowriad
requested review from
ajitbohra,
karmatosed,
mapk,
nerrad,
ntwb and
talldan
as code owners
|
Let’s try it and reconsider later if it proves to be problematic. |
dmsnell
added a commit
that referenced
this pull request
Oct 26, 2022
In #23818 we added the `--ci` command-line arg to the performance test runner to detect if we were running in a CI context. However, if our script is running inside Github Actions then the `ENV['CI']` value will be set. In this patch we're removing the command-line arg and relying on the `ENV` value in order to simplify the script's interface. This is part of a larger refactor to the performance test script and is an early change to minimize subsequent larger changes.
dmsnell
added a commit
that referenced
this pull request
Oct 27, 2022
In #23818 we added the `--ci` command-line arg to the performance test runner to detect if we were running in a CI context. However, if our script is running inside Github Actions then the `ENV['CI']` value will be set. In this patch we're removing the command-line arg and relying on the `ENV` value in order to simplify the script's interface. This is part of a larger refactor to the performance test script and is an early change to minimize subsequent larger changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to check the performance of PRs quickly.