Block Navigation: Change the visible labels for "Block navigation" to "List view". #23796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunandrews
added
the
[Feature] List View
|
Size Change: +4 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
ZebulanStanphill
approved these changes
Jul 8, 2020
| @@ -34,7 +34,7 @@ function BlockNavigation( { | |||
| return ( | |||
| <div className="block-editor-block-navigation__container"> | |||
| <p className="block-editor-block-navigation__label"> | |||
| { __( 'Block navigation' ) } | |||
| { __( 'List view' ) } | |||
There was a problem hiding this comment.
Personally, I would prefer "Tree view", but this is already a big improvement over the current name.
There was a problem hiding this comment.
To me, tree's are better in the forest. Kidding aside, I'm not sure most people know the concept of a "tree" view — it feels a little "inside baseball;" Jargon that is mostly unknown.
A list is a really simple concept, and I suspect more universally understandable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22814
This PR changes the label "Block navigation" to "List view":
Unclear to me if we should rename the component in general.