Remove target="_blank" from View Post message #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WordPress core removed target="_blank" from most of core: https://core.trac.wordpress.org/ticket/23432 WordPress core also has standardized around "Previews are new windows, views are not": https://core.trac.wordpress.org/browser/trunk/src/wp-admin/edit-form-advanced.php#L92
|
I'm so used to use
It would be nice to see Gutenberg follow the established patterns in core, they're there for good reasons. |
afercia
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordPress core removed target="_blank" from most of core: https://core.trac.wordpress.org/ticket/23432
WordPress core also has standardized around "Previews are new windows, views are not": https://core.trac.wordpress.org/browser/trunk/src/wp-admin/edit-form-advanced.php#L92
Related: #1105
cc/ @afercia