Fix odd usage of transform-styles wrap function (and tighten types). #23599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
ZebulanStanphill
force-pushed
the
fix/confusing-transform-styles-wrap-usage
branch
from
dd758ec to
bc53a29
Compare
ZebulanStanphill
force-pushed
the
fix/confusing-transform-styles-wrap-usage
branch
from
bc53a29 to
8e1f1db
Compare
ajlende
approved these changes
Oct 13, 2021
ZebulanStanphill
deleted the
fix/confusing-transform-styles-wrap-usage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the unit tests for the
wrapfunction inpackages/block-editor/src/utils/transform-styles/transforms/wrap.jswas using the function incorrectly, passing a string as the second argument rather than an array of strings. This didn't cause a test failure, because the code coincidentally still worked, due to strings and arrays both having a method calledincludes, which in the case of a string is used to find substrings.While in this case it was harmless, this undefined behavior could result in issues if the
ignoreargument was something likea, which would match not onlya, but alsoarticle,address, and other selectors that happen to contain the substringa.This PR fixes the unit test and tightens the types on the
wrapfunction to try and prevent future misuse.Checklist: