-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Run e2e tests only as an admin #23588
Conversation
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
@youknowriad so many failures, that are concerning, to be honest. The question is whether we want to resolve them or we are good running all tests as admin? We were fine for nearly a yeat if I located the commit that caused the tests to not run as an author... |
It seems the solution for me is to have more targetted author tests so fine to keep the admin only for now. |
0f095db
to
a71269b
Compare
I updated this branch to run tests only as an admin based on the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
@youknowriad discovered lately that we run e2e tests twice for the admin user. This PR tries two things:
How has this been tested?
GitHub actions should pass.