Changed retry icon color #23555
Closed
Changed retry icon color #23555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2020 14:24
antonis
force-pushed
the
rnmobile/2429-Media_Text_Failed_upload_retry_icon_color
branch
from
d57f8e0 to
dba2a1f
Compare
chipsnyder
reviewed
Jun 29, 2020
| <Path d="M17.65 6.35C16.2 4.9 14.21 4 12 4c-4.42 0-7.99 3.58-7.99 8s3.57 8 7.99 8c3.73 0 6.84-2.55 7.73-6h-2.08c-.82 2.33-3.04 4-5.65 4-3.31 0-6-2.69-6-6s2.69-6 6-6c1.66 0 3.14.69 4.22 1.78L13 11h7V4l-2.35 2.35z" /> | ||
| <Path | ||
| d="M17.65 6.35C16.2 4.9 14.21 4 12 4c-4.42 0-7.99 3.58-7.99 8s3.57 8 7.99 8c3.73 0 6.84-2.55 7.73-6h-2.08c-.82 2.33-3.04 4-5.65 4-3.31 0-6-2.69-6-6s2.69-6 6-6c1.66 0 3.14.69 4.22 1.78L13 11h7V4l-2.35 2.35z" | ||
| fill="#ffffff" |
There was a problem hiding this comment.
Hey, I wanted to document what we talked about in our chat a little bit ago.
In image block, we're using a style attribute and then setting that on the icon.
I think it might be good to continue this pattern instead of setting it in the SVG. Looking at the media-container it looks like we're trying to set the style already. I think it would be worth exploring why that isn't working.
PS. We talked about reusing the retry UI but looking deeper into that suggestion I think that would be an effort for a dedicated issue.
There was a problem hiding this comment.
Closing PR since it is already handled by #22788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#2429
Related PRs:
gutenberg-mobile TBD
WordPress-iOS TBD
WordPress-Android TBD
Description
This fix changes the colour of the retry icon in case of upload failure to match the colour of the text. This also aligns the design with other components (e.g. Image)
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: