Add option to keep caret inside block in edit mode #23546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Focus] Accessibility (a11y)
tellthemachines
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
mkaz and
youknowriad
as code owners
6 tasks
|
Size Change: -338 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jun 29, 2020
|
Hi @tellthemachines 👋 I just tested this PR and everything worked as expected to me.
I saw the new option and after turning it on, I was able to confirm that the caret stays constrained in the block. Turning it back off took me back to the default behaviour. |
youknowriad
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
Code wise this is looking good.
cc @mtias @jasmussen do you have thoughts here?
|
This seems good. On the one hand, it's good that the label is short and simple. But on the other hand, this is quite a profound change to the editor — it may be exactly what you're looking for, or it may break your experience entirely. I wonder if there's a more descriptive label we can find, or whether this may even be a place to add help text. "Cursor", for example, may even be imprecise, as you can move your cursor anywhere. Short option: This is a bit more technical, actually, so not sure it's an improvement. But it feels more precise. Longer option: Regardless of what we go with, I would say it's good to merge sooner rather than later, because it's a good option and we can alwasy polish the label if need be. |
|
Tested using NV Access in Firefox, works fine. |
|
@jasmussen I went with the short option for now; we can always review it later. Thanks everyone for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #22190, builds on #22204.
Added "Keyboard options" section in "More tools & options > Options" modal, with checkbox labelled "Keep cursor inside active block". Checking it will stop arrow keys from navigating between blocks in edit mode. Navigation mode is not affected.
How has this been tested?
Tested in browser with keyboard.
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: