UnitControl: Fix internal unit parsing to handle incoming unit prop #23521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prop This update fixes the `<UnitControl />` component to handle (new) incoming `unit` prop changes. This is important for handling interactions such as unit swapping - an interaction we have for the Cover block.
ItsJonQ
added
[Type] Bug
ItsJonQ
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
|
Size Change: -15 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
2 tasks
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2020
…prop (#23521) This update fixes the `<UnitControl />` component to handle (new) incoming `unit` prop changes. This is important for handling interactions such as unit swapping - an interaction we have for the Cover block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes the
<UnitControl />component to handle (new) incomingunitprop changes. This is important for handling interactions such as unit swapping - an interaction we have for the Cover block.In the GIF demo above, we manually change the unit from
pxtoem. Afterwards, we drag to resize the cover. Dragging automatically switches the unit back topx.How has this been tested?
Local storybook, Jest, and local Gutenberg
Run
npm run devAdd a Cover block
Change the height
Change the unit to a non
pxvalue.Drag to resize Cover
Ensure the unit updates back to
pxChecklist:
This is a fast followup to #23006