Table block: Fix focus loss in between row/column insertions. #23508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
force-pushed
the
fix/table-enable-buttons-add-more-than-one
branch
from
6284ece to
71be636
Compare
ntsekouras
added
[Block] Table
|
Size Change: +2.02 kB (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
This just allows to be able to add more rows, by enabling the corresponding buttons. It needs to be revised when programmatically focus to RichText is handled.
ntsekouras
force-pushed
the
fix/table-enable-buttons-add-more-than-one
branch
from
71be636 to
22daaf8
Compare
mcsf
requested changes
Jul 6, 2020
There was a problem hiding this comment.
I think some clear testing instructions for this pull request would be very helpful, since the issue isn't obvious to reproduce consistently.
I'm glad you link to #9740, I think that's useful context to have. That said, my first impression is that we can best address the current Table issue by finding what — if anything — we can do at the DOM-event level to mitigate the issue.
Comment on lines
302
to
308
| // this just allows to be able to add more rows, by enabling the corresponding | ||
| // buttons. It needs to be revised when programmatically focus to RichText is handled | ||
| this.createOnFocus( { | ||
| sectionName, | ||
| rowIndex: newRowIndex, | ||
| columnIndex: 0, | ||
| } ); |
There was a problem hiding this comment.
By definition, createOnFocus just returns a new function but doesn't do anything with it. So I'm fairly sure that nothing is happening here. :)
There was a problem hiding this comment.
Thanks Miguel. I saw the code now and couldn't understand why I left it that way... Maybe when I was trying to find how to focus on RichText..?
I changed it to just change the selected cell in state.
Comment on lines
363
to
368
| // this just allows to be able to add more rows, by enabling the corresponding | ||
| // buttons. It needs to be revised when programmatically focus to RichText is handled | ||
| this.createOnFocus( { | ||
| rowIndex: 0, | ||
| columnIndex: newColumnIndex, | ||
| } ); |
mcsf
approved these changes
Jul 6, 2020
Co-authored-by: Miguel Fonseca <[email protected]>
Co-authored-by: Miguel Fonseca <[email protected]>
|
Nice fix! |
|
Thank you. I'll be so glad when I can add rows easier. I have a few situations where I need to go to an existing table and add 20-30 at a time. This will cut down on clicks. |
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2020
* Enable add row/column buttons after having added one. This just allows to be able to add more rows, by enabling the corresponding buttons. It needs to be revised when programmatically focus to RichText is handled. * set selected cell in state * Change comment description Co-authored-by: Miguel Fonseca <[email protected]> * Change comment description Co-authored-by: Miguel Fonseca <[email protected]> Co-authored-by: Miguel Fonseca <[email protected]>
mcsf
changed the title
mcsf
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23103
This PR just allows to be able to add more rows/columns, by enabling the corresponding buttons, after having added a row/column.
To reproduce what happens now:
Tableblock ( ex 2x2 ) and insert some text in a cellToolbarand clickAdd a row Before/AfterToolbaragain and in the Dropdown menu for adding rows you'll see that everything is disabledOther enhancements on
Tableblock can be handled separately, such as adding keyboard support for some actions.It needs to be revised when programmatically focus to RichText is handled, as mentioned here #9740.
How has this been tested?
Screenshots
Types of changes
Checklist: