Remove duplicate selectors #23466
Merged
Remove duplicate selectors #23466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajitbohra
added
the
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
ajitbohra
added
the
Good First Review
talldan
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Often these are added this way to increase specificity.
I looked back through the history though, and it doesn't seem that was the case here, so I think it's good to remove this duplication.
Originally these were attribute selectors, and one of the lines included a space - #13248 (comment)
Then they were replaced with class name selectors, but duplicated - #16779
I tested Twenty Nineteen, Twenty Twenty and Gutenberg Starter Theme and didn't spot any differences.
Twenty Twenty appears to have a bug with its border in the frontend, but it wasn't caused by this PR:
ZebulanStanphill
force-pushed
the
fix/quote-duplicate-selectors
branch
from
dc98477 to
c6563dd
Compare
ZebulanStanphill
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes duplicate selectors from block style
How has this been tested?
Types of changes
Code cleanup
Checklist: