Classic block: Adjust placement of classic block toolbar when scrolled to top #23438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1 B Total Size: 1.13 MB
ℹ️ View Unchanged
|
talldan
added
[Type] Bug
talldan
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Thanks @glendaviesnz for working on this. In my testing this seems much better than the existing behavior, so I think we should go ahead and merge this.
I've added Needs Design Feedback as it's I think it's a shame the block toolbar is covered. The only alternative is perhaps having both toolbars act as one sticky toolbar, but that might be tricky to achieve.
Having said that, I'm going to merge this anyway 😄
|
Thank you for this definitely a much better experience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #20969
How has this been tested?
Manual testing
Screenshots
Before:
After:
Types of changes
Checklist: